HuaHuaY commented on code in PR #50807:
URL: https://github.com/apache/arrow/pull/50807#discussion_r3719408195
##########
cpp/src/parquet/schema.cc:
##########
@@ -620,6 +620,12 @@ void ToParquet(const GroupNode* schema,
std::vector<format::SchemaElement>* out)
schema->VisitConst(&visitor);
}
+bool IsFloatingPoint(const ColumnDescriptor& descr) {
+ return descr.physical_type() == Type::FLOAT || descr.physical_type() ==
Type::DOUBLE ||
+ (descr.physical_type() == Type::FIXED_LEN_BYTE_ARRAY &&
descr.logical_type() &&
Review Comment:
I think we only need to check the logical type here. I will delete the code
which check physical type of `FLOAT16`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
