dhruvxvaishnav commented on code in PR #10559:
URL: https://github.com/apache/arrow-rs/pull/10559#discussion_r3719606240
##########
arrow-ord/src/rank.rs:
##########
@@ -60,6 +62,7 @@ pub fn rank(array: &dyn Array, options: Option<SortOptions>)
-> Result<Vec<u32>,
DataType::LargeUtf8 => bytes_rank(array.as_bytes::<LargeUtf8Type>(),
options),
DataType::Binary => bytes_rank(array.as_bytes::<BinaryType>(),
options),
DataType::LargeBinary =>
bytes_rank(array.as_bytes::<LargeBinaryType>(), options),
+ DataType::Utf8View => byte_view_rank(array.as_string_view(), options),
Review Comment:
Good point—yes, I will add BinaryView support and corresponding test
coverage for completeness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
