tom-eon commented on PR #1036: URL: https://github.com/apache/arrow-go/pull/1036#issuecomment-5202193785
@zeroshade Done — the cost fallback is now gated on the column's codec being uncompressed, which fixes the misprediction by default: the uncompressed-size comparison only predicts on-disk cost when no codec is configured. I also dropped the blanket `WithDictionaryCostFallback` option; what remains is the per-column `WithDictionaryCostFallbackFor`, which now overrides the codec-based default in either direction (`false` keeps a dictionary on an uncompressed column, `true` forces the check on a compressed one). Tests cover both directions plus the codec-aware default at global and per-column compression levels. Updated the PR description to match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
