bit2swaz commented on PR #10431: URL: https://github.com/apache/arrow-rs/pull/10431#issuecomment-5238044162
> we dont need to repeat ourselves in the internal struct field documentation, just simply state its for safety reasons. then on the setters themselves we can put the safety requirements done and applied it to all three structs. the struct fields just say theyre private for safety now, and the safety details live on the setters. i moved the wrap-release note + #9771 link onto `set_release` too so it doesnt get lost btw, i applied your suggestions by hand so the three structs stay consistent, so the diff already has them. best to not click "commit suggestion" or itll double up. lmk if the wording works for you :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
