bit2swaz commented on PR #10431: URL: https://github.com/apache/arrow-rs/pull/10431#issuecomment-5240718266
> does this also close #10253? yep. #10253 was the same hole on the stream: safe [try_new](https://github.com/apache/arrow-rs/blob/4a410c1d3a499271117980c8cad29a1e6e6cd431/arrow-array/src/ffi_stream.rs#L362) ends up calling a caller-supplied `get_schema` fn pointer so with `pub` fields you could hand it a garbage stream and hit UB with no `unsafe` anywhere private fields shut that path and #10253 offered private fields as one of its two fixes. `try_new` can stay safe now since a safe caller cant build a bogus stream. ill add a closes line for it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
