domibel commented on code in PR #50799:
URL: https://github.com/apache/arrow/pull/50799#discussion_r3781116457
##########
cpp/src/gandiva/engine.cc:
##########
@@ -140,6 +140,9 @@ Result<llvm::orc::JITTargetMachineBuilder>
MakeTargetMachineBuilder(
const Configuration& conf) {
llvm::orc::JITTargetMachineBuilder jtmb(
(llvm::Triple(llvm::sys::getDefaultTargetTriple())));
+#if defined(__riscv)
+ jtmb.setRelocationModel(llvm::Reloc::PIC_);
+#endif
Review Comment:
The other archs are defaulting to llvm::Reloc::Static , so that change needs
to be carefully tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
