AntoinePrv commented on PR #50827: URL: https://github.com/apache/arrow/pull/50827#issuecomment-5313525121
> Could you update the PR description to also include `dl_device` under the support in `__dlpack__`? Sure thing. > with the change to use `raw_data` for a tensor, an immutable tensor can now be exported via the legacy path but we can't flag it as read-only using `DLManagedTensor`. Could that be a problem? I noticed that too, but I did not find any good solution. The previous implementation would return `nullptr`, making it unusable. However that clashes with the `Array` which by convention is immutable (but returning `nullptr` would make that DLPack API useless then). > Maybe we could safe-guard that on the Python side also in order for the user to not use legacy path with immutable tensors? That sounds like the most reasonable option actually. But what do you think of the discrepancy with `Array`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
