AntoinePrv commented on PR #50827: URL: https://github.com/apache/arrow/pull/50827#issuecomment-5324681104
> Since this is an already existing behavior, I would keep it as is but would safeguard the new case of immutable Tensor on the legacy path. Just to be sure we don't let users start depending on unmarked-mutable exports of immutable tensors. Done. > I would also make it explicit in the documentation that the use of the new protocol version is advised, specifically in immutable Array cases. Done as well > As for the deprecation of the legacy path: would it make sense to already deprecate the path now (in C++ and Python both) and change the default to the versioned path in the next release? I understand it is additional work and could be postponed to a follow-up and I would not block that, but would prefer deprecating it now. I've done the Python version, but for the C++ side, I've had trouble in the past using `ARROW_DEPRECATED` while still using the function internally (raise a warning turned into error in CI). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
