alamb commented on code in PR #10708:
URL: https://github.com/apache/arrow-rs/pull/10708#discussion_r3806756603
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -306,6 +306,23 @@ impl<T: ByteViewType + ?Sized> GenericByteViewArray<T> {
&self.buffers
}
+ /// Returns a cloned `Arc` of the buffers storing non-inline string or
binary data.
Review Comment:
I wonder if we should just change the other APIs be consistent -- like make
`data_buffers` return `&Arc<[Buffer]>` and change `new_unchecked` to take
Arc<[Buffer]> directly (rather than `Into<Arc<[Buffer]>>` )
That way we could find more places that unecessairly copy these buffers 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
