YimingQiao commented on code in PR #10708:
URL: https://github.com/apache/arrow-rs/pull/10708#discussion_r3826984164
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -306,6 +306,23 @@ impl<T: ByteViewType + ?Sized> GenericByteViewArray<T> {
&self.buffers
}
+ /// Returns a cloned `Arc` of the buffers storing non-inline string or
binary data.
Review Comment:
That worked nicely. I changed `data_buffers()` to return `&Arc<[Buffer]>`
and made `new_unchecked` take `Arc<[Buffer]>` directly. Letting the compiler
drive the update found three more `.to_vec()` call sites in the FFI, IPC, and
Parquet tests; those now use `Arc::clone`, while callers that genuinely
construct new buffer lists convert them explicitly. The workspace checks,
relevant tests, clippy, and rustdoc all pass locally. This changes two public
signatures, and I do not have permission to add labels here, so could you add
`api-change` if appropriate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
