haohuaijin commented on code in PR #10702:
URL: https://github.com/apache/arrow-rs/pull/10702#discussion_r3812461652
##########
parquet/src/arrow/arrow_reader/mod.rs:
##########
@@ -219,11 +349,15 @@ impl<T> ArrowReaderBuilder<T> {
/// Only read data from the provided row group indexes
///
/// This is also called row group filtering
- pub fn with_row_groups(self, row_groups: Vec<usize>) -> Self {
- Self {
- row_groups: Some(row_groups),
- ..self
- }
+ ///
+ /// On [`ParquetPushDecoderBuilder`] and async stream builders, which
+ /// additionally offer `with_row_group_selections`, this cannot be combined
+ /// with that method; attempting to do so returns an error from `build`.
+ ///
+ /// [`ParquetPushDecoderBuilder`]:
crate::arrow::push_decoder::ParquetPushDecoderBuilder
+ pub fn with_row_groups(mut self, row_groups: Vec<usize>) -> Self {
Review Comment:
yes, i also consider deprecate the old method, and only support
`with_row_group_selections`, but the sync reader do not support this, so i not
do this.
but for sync reader, maybe we can support `with_row_group_selections`
method, but when `build` convert it to the file level `RowSelection`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
