haohuaijin commented on code in PR #10702:
URL: https://github.com/apache/arrow-rs/pull/10702#discussion_r3812534114
##########
parquet/src/arrow/push_decoder/remaining.rs:
##########
@@ -42,21 +44,78 @@ enum QueuedRowGroupDecision {
struct NextRowGroup {
row_group_idx: usize,
row_count: usize,
- /// This row group's slice of the global selection, or `None` when all rows
- /// are selected.
+ /// This row group's selection, or `None` when all rows are selected.
selection: Option<RowSelection>,
/// Budget snapshot to apply while decoding this row group.
budget: RowBudget,
}
+#[derive(Debug, Clone)]
+enum QueuedRowGroups {
Review Comment:
yes, it is much simpler. if we finally deprecate the old method, and only
support `with_row_group_selections`. we can do this convert when `build` when
deprecate old method. and then finally remove the deprecate method after few
release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
