ethantang93 opened a new pull request, #10803: URL: https://github.com/apache/arrow-rs/pull/10803
# Which issue does this PR close? closes #614 # Rationale for this change Follow-up to #10507, which added Miri coverage for the arrow crates but left parquet excluded because it was tracked separately in #614. This adds the parquet crate to the Miri workflow to detect undefined behavior in its unsafe code. the full parquet miri run took about 40mins on my M3 laptop # What changes are included in this PR? - Adds `-p parquet` to the Miri test suite in `miri.sh` - Adds `parquet/**` to the workflow path filters in `miri.yaml` - adds ignore to tests that take too long to run under Miri - adds ignore to tests that hit operations Miri doesn't support: kqueue, fork, inline assembly, native Zstd C functions # Are these changes tested? i ran the following to test locally. - `MIRIFLAGS="-Zmiri-disable-isolation" cargo +nightly miri nextest run -p parquet` - `cargo test -p parquet` - `cargo fmt --check -p parquet` - `git diff --check` # Are there any user-facing changes? no, only tests and CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
