Jefffrey commented on code in PR #10803:
URL: https://github.com/apache/arrow-rs/pull/10803#discussion_r3869007704
##########
parquet/tests/arrow_reader/statistics.rs:
##########
@@ -373,6 +373,7 @@ impl Test<'_> {
// Remaining cases
// f64::NAN
+#[cfg_attr(miri, ignore)] // kqueue unsupported by Miri
Review Comment:
is this only a macos issue? for reference
- https://github.com/rust-lang/miri/issues/4007
perhaps we can gate it for macos, since our runners are ubuntu so we can try
run these tests as part of CI
##########
parquet/src/bloom_filter/mod.rs:
##########
@@ -870,7 +873,7 @@ mod tests {
(0.1, 1000000, 5772541),
(0.01, 1000000, 9681526),
(0.001, 1000000, 14607697),
- (1e-50, 1_000_000_000_000, 14226231280773240832),
+ (1e-9, 10_000_000, 1026297530),
Review Comment:
maybe we can just gate this specific test case from miri using `#[cfg()]`
and leave it unchanged?
##########
parquet/tests/arrow_reader/io/sync_reader.rs:
##########
@@ -320,6 +328,7 @@ fn test_read_multiple_row_filter() {
}
#[test]
+#[cfg_attr(miri, ignore)] // fork is not supported
Review Comment:
similar question here, is this an issue of macos support or just fork
support in general?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
