Jefffrey commented on code in PR #10884:
URL: https://github.com/apache/arrow-rs/pull/10884#discussion_r3870915248
##########
arrow-array/src/array/union_array.rs:
##########
@@ -1128,7 +1128,6 @@ mod tests {
}
#[test]
- #[cfg_attr(miri, ignore)]
Review Comment:
i think it took 30 seconds on my M4 mac machine, so I think its fine to
enable
##########
arrow-buffer/src/bigint/mod.rs:
##########
@@ -1819,7 +1819,7 @@ mod tests {
}
#[test]
- #[cfg_attr(miri, ignore)]
+ #[cfg_attr(miri, ignore)] // conversion to float isn't accurate under miri
Review Comment:
```
thread 'bigint::tests::test_decimal256_to_f64_typical_values' (82672)
panicked at arrow-buffer/src/bigint/mod.rs:1825:9:
assertion `left == right` failed
left: 41.99999999999997
right: 42.0
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
note: in Miri, you may have to set
`MIRIFLAGS=-Zmiri-env-forward=RUST_BACKTRACE` for the environment variable to
have an effect
```
didnt spend any time looking into this, im sure theres a deeper reason here
##########
arrow-cast/src/parse.rs:
##########
@@ -1611,7 +1611,6 @@ mod tests {
}
#[test]
- #[cfg_attr(miri, ignore)] // unsupported operation: can't call foreign
function: mktime
Review Comment:
seems to run fine, at least on macos
##########
arrow-buffer/src/util/bit_chunk_iterator.rs:
##########
@@ -730,7 +730,6 @@ mod tests {
}
#[test]
- #[cfg_attr(miri, ignore)]
Review Comment:
similarly here it took about 30 seconds or so
##########
arrow-schema/src/datatype.rs:
##########
@@ -1271,7 +1271,7 @@ mod tests {
}
#[test]
- #[cfg_attr(miri, ignore)] // Can't handle the inlined strings of the
assert_debug_snapshot macro
+ #[cfg_attr(miri, ignore)] // fork is not supported
Review Comment:
more clear what is not supported here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
