Jefffrey commented on code in PR #10884:
URL: https://github.com/apache/arrow-rs/pull/10884#discussion_r3877404564
##########
arrow-buffer/src/bigint/mod.rs:
##########
@@ -1819,7 +1819,7 @@ mod tests {
}
#[test]
- #[cfg_attr(miri, ignore)]
+ #[cfg_attr(miri, ignore)] // conversion to float isn't accurate under miri
Review Comment:
oh this is quite nice
looking at the miri flags i decided to go with
`-Zmiri-no-extra-rounding-error`, seems to pass locally now 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
