etseidl commented on PR #10840: URL: https://github.com/apache/arrow-rs/pull/10840#issuecomment-5442565869
> > im still unsure on if we should omit the `non-null` for the runs type or not, might be good to get a second opinion > > i'm in favor of removing at since its redundant. > > @etseidl any thoughts? Sorry, I'm going to waffle 😅. I see your point about it being required so the `non-null` is redundant, but then I wonder if that's obvious to all consumers of this. I'm fine with whatever you and @Jefffrey agree to. 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
