mnpw commented on PR #10904: URL: https://github.com/apache/arrow-rs/pull/10904#issuecomment-5528604461
Thanks for reviewing! > What are the downsides to keeping it? Keeping the method just adds noise to the trait definition and it's required to implement as there is no trait level default impl. So every implementor ends up adding a mock implementation for this method that likely doesn't do anything. > Since this is would be a breaking API change we'd need to depreciate it first. I've added this method for deprecation along with a default impl so that it doesn't add noise to newer implementations until we can remove this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
