rustyconover commented on PR #930: URL: https://github.com/apache/arrow-nanoarrow/pull/930#issuecomment-5603831147
Addressed the latest review in 2ae9cd6. - Null storage is now rejected when the destination uses run-end encoded storage, before any destination mutation. - Nested struct/list/fixed-size-list children now recurse through an explicit offset/length range helper, so nested fixed-width storage such as decimals follows the same validated bulk path as top-level storage. - Added regressions for null-to-REE rejection and decimal storage nested in both a struct and a list. - For struct field names: ArrowArrayView does not carry field names, and this API intentionally operates on storage rather than logical schema metadata. I documented that struct children are matched positionally and that callers must validate field names (as well as decimal precision/scale). The public API signature remains unchanged; offset/length are internal to the recursive helper. Validation: - Native CMake/CTest: 280/280 passed. - Arrow C++-gated CMake/CTest: 320/320 passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
