rustyconover commented on PR #930: URL: https://github.com/apache/arrow-nanoarrow/pull/930#issuecomment-5608560417
Addressed the remaining review points in ea0f7 (after merging current upstream/main in 9690f71): - documented that the source view must not reference destination-owned storage, since an append can reallocate it - qualified the shallow src_slice copy - switched int16 REE run lookup to ArrowResolveChunk16() - added bulk struct-to-struct appends, including valid child storage beneath null struct slots - reject other null appends before they can recursively create invalid REE child storage - guard REE destination length addition before any signed overflow or mutation Added regression coverage for int16 REE lookup, struct/REE storage beneath a null parent, nested Null-to-REE rejection, and destination-length overflow. Local validation: all 14 focused append tests pass; the full C/C++ suite passes 284/284 tests (3 expected thread-safety skips). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
