raulcd commented on code in PR #50195:
URL: https://github.com/apache/arrow/pull/50195#discussion_r4034243931
##########
r/configure.win:
##########
@@ -95,8 +95,10 @@ function configure_binaries() {
# S3, GCS, and re2 support only for Rtools40 (i.e. R >= 4.0)
"${R_HOME}/bin${R_ARCH_BIN}/Rscript.exe" -e 'R.version$major >= 4' | grep
TRUE >/dev/null 2>&1
if [ $? -eq 0 ]; then
Review Comment:
Absolutely, I missed the `R (>= 4.2)`. I've just pushed the change, will
validate CI.
##########
cpp/src/arrow/filesystem/CMakeLists.txt:
##########
@@ -119,6 +119,7 @@ if(ARROW_S3)
s3fs_benchmark.cc
s3_test_util.cc
STATIC_LINK_LIBS
+ ${ARROW_S3_TEST_EXTRA_LINK_LIBS}
${AWSSDK_LINK_LIBRARIES}
Review Comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
