raulcd commented on code in PR #50195:
URL: https://github.com/apache/arrow/pull/50195#discussion_r4034347391
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4255,15 +4261,15 @@ if(ARROW_S3)
if(ARROW_BUILD_STATIC)
if(${AWSSDK_SOURCE} STREQUAL "SYSTEM")
foreach(AWSSDK_LINK_LIBRARY ${AWSSDK_LINK_LIBRARIES})
- string(APPEND ARROW_PC_LIBS_PRIVATE "
$<TARGET_FILE:${AWSSDK_LINK_LIBRARY}>")
+ string(APPEND ARROW_S3_PC_LIBS_PRIVATE "
$<TARGET_FILE:${AWSSDK_LINK_LIBRARY}>")
endforeach()
else()
if(UNIX)
- string(APPEND ARROW_PC_REQUIRES_PRIVATE " libcurl")
+ string(APPEND ARROW_S3_PC_REQUIRES_PRIVATE " libcurl")
endif()
- string(APPEND ARROW_PC_REQUIRES_PRIVATE " openssl")
+ string(APPEND ARROW_S3_PC_REQUIRES_PRIVATE " openssl")
if(APPLE)
- string(APPEND ARROW_PC_LIBS_PRIVATE " -framework Security")
+ string(APPEND ARROW_S3_PC_LIBS_PRIVATE " -framework Security")
endif()
Review Comment:
This is pre-existing and has never been raised as a problem so ... not part
of this PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
