etseidl commented on code in PR #11031:
URL: https://github.com/apache/arrow-rs/pull/11031#discussion_r4097536069
##########
parquet/src/file/metadata/writer.rs:
##########
@@ -270,34 +249,24 @@ impl<'a, W: Write> ThriftMetadataWriter<'a, W> {
created_by: Option<String>,
writer_version: i32,
write_path_in_schema: bool,
+ preserve_page_index_locations: bool,
) -> Self {
Self {
buf,
schema_descr,
row_groups,
- column_indexes: None,
- offset_indexes: None,
+ page_index: None,
key_value_metadata: None,
created_by,
object_writer: Default::default(),
writer_version,
write_path_in_schema,
+ preserve_page_index_locations,
}
}
- pub fn with_column_indexes(
- mut self,
- column_indexes: Vec<Vec<Option<ColumnIndexMetaData>>>,
- ) -> Self {
- self.column_indexes = Some(column_indexes);
- self
- }
-
- pub fn with_offset_indexes(
- mut self,
- offset_indexes: Vec<Vec<Option<OffsetIndexMetaData>>>,
- ) -> Self {
- self.offset_indexes = Some(offset_indexes);
+ pub fn with_page_index(mut self, page_index: Arc<dyn PageIndexProvider>)
-> Self {
Review Comment:
Will do. I found a similarly confusing pub in #11157. I'll have to do some
issue hunting, but did we bring up adding lints to flag unnecessary `pub`
visibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
