etseidl commented on code in PR #11031:
URL: https://github.com/apache/arrow-rs/pull/11031#discussion_r4097548331
##########
parquet/src/file/metadata/writer.rs:
##########
@@ -443,6 +411,23 @@ impl<'a, W: Write> ParquetMetaDataWriter<'a, W> {
}
}
+ /// Set whether or not to preserve the page index location metadata in the
Thrift
+ /// `ColumnMetaData`.
+ ///
+ /// Because this struct is often used to externalize the footer metadata,
it is
+ /// usually desirable to preserve this location information, even when the
+ /// page indexes are not duplicated (for instance if the provided
`ParquetMetaData`
+ /// returns no `PageIndexProvider`). As such, this defaults to `true`.
+ ///
+ /// Set this to `false` to reset the location metadata if no page indexes
are
Review Comment:
I agree, and that's next on my list once we're done fiddling with the page
indexes 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
