neilconway commented on code in PR #11199:
URL: https://github.com/apache/arrow-rs/pull/11199#discussion_r4106851466
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -674,6 +765,9 @@ fn timestamp_to_date32<T: ArrowTimestampType>(
/// * `Date32` and `Date64`: precision lost when going to higher interval
/// * `Time32` and `Time64`: precision lost when going to higher interval
/// * `Timestamp` and `Date{32|64}`: precision lost when going to higher
interval
+/// * `Timestamp` without a timezone to `Date32`, `Time32`, or `Time64`:
supports
+/// timestamps outside Chrono's date range. A `Date32` day count that does
not fit
+/// in `i32` returns an error, regardless of [`CastOptions::safe`].
Review Comment:
> If we keep the new behavior instead, the api-change label would make sure
it shows up in the changelog
WRT `api-change` specifically, I don't believe this qualifies as an API
change (per Rust RFC 1105). But happy to add such a label if you'd prefer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
