tadeja commented on code in PR #51280:
URL: https://github.com/apache/arrow/pull/51280#discussion_r4122804534
##########
ci/scripts/cpp_test.sh:
##########
@@ -143,15 +143,26 @@ if [ "${ARROW_USE_MESON:-OFF}" = "OFF" ] && \
# Search vcpkg before <prefix>/lib/cmake.
CMAKE_PREFIX_PATH="${VCPKG_ROOT}/installed/${VCPKG_DEFAULT_TRIPLET};${CMAKE_PREFIX_PATH}"
fi
+ ARROW_EXAMPLE_S3="${ARROW_S3:-OFF}"
+ if [ "${ARROW_ENABLE_THREADING:-ON}" = "OFF" ]; then
+ ARROW_EXAMPLE_S3=OFF
+ fi
Review Comment:
Not for Emscripten, but for no-threading nightly job. [Without the
guard](https://github.com/apache/arrow/pull/51280/changes/9af899f822729d4baca694085059ede3c98f949f)
the failure is replicated
[here](https://github.com/apache/arrow/pull/51280#issuecomment-5869805773):
[+
ARROW_S3=OFF](https://github.com/ursacomputing/crossbow/actions/runs/36421757932/job/108925914948#step:7:190)
then
[cmake .../minimal_build
-DARROW_EXAMPLE_S3_STATIC_CHECK=ON](https://github.com/ursacomputing/crossbow/actions/runs/36421757932/job/108925914948#step:7:3057)
and
`CMake Error at CMakeLists.txt:55 (find_package):
By not providing "FindArrowS3.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "ArrowS3", but
CMake did not find one.`
The job `test-ubuntu-22.04-cpp-no-threading` passed [before removing the
guard](https://github.com/apache/arrow/pull/51280#issuecomment-5869705620) and
[again passes with the re-added
guard](https://github.com/apache/arrow/pull/51280#issuecomment-5870609272)
https://github.com/ursacomputing/crossbow/actions/runs/36427162332/job/108943852881#step:7:3166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
