raulcd commented on code in PR #51488:
URL: https://github.com/apache/arrow/pull/51488#discussion_r4121191034
##########
ci/scripts/python_build_emscripten.sh:
##########
@@ -44,5 +44,7 @@ if [ "${GITHUB_ACTIONS:-}" = "true" ]; then
fi
pushd "${python_build_dir}"
+# For LLVM 23 llvm-strip to not remove required dylink.0
+export SKBUILD_INSTALL_STRIP=false
Review Comment:
I am wondering whether we want this happening on the rest of the wheels too.
Should we just try to add this section to the `pyproject.toml`:
```toml
[tool.scikit-build]
install.strip = false
```
We manually strip debug symbols on wheels when building but I am unsure we
want to strip all as discussed in the past. Details here:
- https://github.com/apache/arrow/issues/40749#issuecomment-2045586715
@rok what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
