raulcd commented on code in PR #51488:
URL: https://github.com/apache/arrow/pull/51488#discussion_r4141828287
##########
ci/scripts/python_build_emscripten.sh:
##########
@@ -44,5 +44,7 @@ if [ "${GITHUB_ACTIONS:-}" = "true" ]; then
fi
pushd "${python_build_dir}"
+# For LLVM 23 llvm-strip to not remove required dylink.0
+export SKBUILD_INSTALL_STRIP=false
Review Comment:
I think we can merge this. This seems to have been the behaviour since
scikit-build-core 0.5 and we've had several releases with it. No need to change
current behavior globally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
