Copilot commented on code in PR #51610:
URL: https://github.com/apache/arrow/pull/51610#discussion_r4121306338


##########
.github/workflows/cpp_windows.yml:
##########
@@ -115,12 +115,17 @@ jobs:
         with:
           path: ${{ steps.ccache-info.outputs.cache-dir }}
           key: cpp-ccache-windows-${{ inputs.arch }}
+      - name: Find Visual Studio
+        shell: bash
+        run: |
+          vs_path=$("/c/Program Files (x86)/Microsoft Visual 
Studio/Installer/vswhere.exe" -latest -property installationPath)
+          echo "VS_INSTALL_PATH=${vs_path}" >> "${GITHUB_ENV}"

Review Comment:
   The ARM caller still passes `os: windows-11-arm`, but the linked 
runner-image announcement identifies `windows-11-vs2026-arm` as the image 
containing Visual Studio and lists Visual Studio as unavailable on the plain 
Windows 11 Arm64 image. On the current caller, `vswhere` will therefore be 
absent or return no installation, leaving `VS_INSTALL_PATH` empty and causing 
the subsequent `vcvarsall.bat` call to fail; please switch the ARM caller to a 
VS-equipped runner (or provision VS) as part of this fix.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to