rok commented on code in PR #51404:
URL: https://github.com/apache/arrow/pull/51404#discussion_r4137117567
##########
python/pyarrow/tests/test_compute.py:
##########
@@ -2657,7 +2657,9 @@ def _check_datetime_components(timestamps, timezone=None):
assert pc.is_leap_year(tsa).equals(pa.array(ts.dt.is_leap_year))
assert pc.month(tsa).equals(pa.array(month))
assert pc.day(tsa).equals(pa.array(day))
+
assert pc.day_of_week(tsa).equals(pa.array(dayofweek))
+
assert pc.day_of_year(tsa).equals(pa.array(dayofyear))
Review Comment:
I'm not sure this renders for me correctly. What I'm seeing is two new lines
and no other changes. I'd avoid adding new lines here. But maybe my viewer is
busted and I'm not seeing the correct change?
```suggestion
assert pc.day(tsa).equals(pa.array(day))
assert pc.day_of_week(tsa).equals(pa.array(dayofweek))
assert pc.day_of_year(tsa).equals(pa.array(dayofyear))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
