jorisvandenbossche commented on code in PR #51404:
URL: https://github.com/apache/arrow/pull/51404#discussion_r4168355609
##########
python/pyarrow/tests/test_pandas.py:
##########
@@ -99,8 +99,8 @@ def _alltypes_example(size=100):
def _check_pandas_roundtrip(df, expected=None, use_threads=False,
expected_schema=None,
- check_dtype=True, schema=None,
- preserve_index=False,
+ check_dtype=True, check_freq=False,
Review Comment:
But so (AFAIK) `check_freq` _was_ already enabled and verified in most
cases, and only not in the case of eg a MultiIndex. Thus, setting it to False
here means that some cases where we were currently asserting equal `freq`, will
no longer be checked.
To be fair, I don't know if that is much of a problem, though .. Since you
noted, we typically don't do any effort to ensure there is a correct freq set.
But, I think it should also be quite easy to just update the failing test.
Eg in `test_column_index_names_datetime`, pass `check_freq=False` if you pass
kwargs in `_check_pandas_roundtrip` to the `assert_frame_equal` call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
