Phoenix500526 commented on code in PR #11184:
URL: https://github.com/apache/arrow-rs/pull/11184#discussion_r4171144099
##########
parquet/tests/arrow_writer/roundtrip_helpers.rs:
##########
@@ -127,39 +109,12 @@ impl RoundTripTest {
}
}
- /// Set the schema
- pub(super) fn with_schema(mut self, schema: SchemaRef) -> Self {
- self.schema = Some(schema);
- self
- }
-
/// Set the nullable flag
pub(super) fn with_nullable(mut self, nullable: bool) -> Self {
self.nullable = nullable;
self
}
- /// Set bloom filter
- pub(super) fn with_bloom_filter(mut self, bloom_filter: bool) -> Self {
- self.bloom_filter = bloom_filter;
- self
- }
-
- /// Set bloom filter max ndv
- pub(super) fn with_bloom_filter_ndv(mut self, bloom_filter_ndv: u64) ->
Self {
- self.bloom_filter_ndv = Some(bloom_filter_ndv);
Review Comment:
> so we've split out these impls, because `with_schema` is only used in the
integration tests whilst the rest are only used in the unit tests, right?
Exactly.
> is this split going to be permanent too, or a temporary measure as we move
tests in follow up PRs?
It will be permanent. Bloom filter-specific tests will stay in the unit test
suite, while general data round-trip tests belong in the integration test
suite. The two suites share the excution logic but define thir own
purpose-specific configuration methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
