Jefffrey commented on code in PR #11184:
URL: https://github.com/apache/arrow-rs/pull/11184#discussion_r4173179985
##########
parquet/tests/arrow_writer/roundtrip_helpers.rs:
##########
@@ -127,39 +109,12 @@ impl RoundTripTest {
}
}
- /// Set the schema
- pub(super) fn with_schema(mut self, schema: SchemaRef) -> Self {
- self.schema = Some(schema);
- self
- }
-
/// Set the nullable flag
pub(super) fn with_nullable(mut self, nullable: bool) -> Self {
self.nullable = nullable;
self
}
- /// Set bloom filter
- pub(super) fn with_bloom_filter(mut self, bloom_filter: bool) -> Self {
- self.bloom_filter = bloom_filter;
- self
- }
-
- /// Set bloom filter max ndv
- pub(super) fn with_bloom_filter_ndv(mut self, bloom_filter_ndv: u64) ->
Self {
- self.bloom_filter_ndv = Some(bloom_filter_ndv);
Review Comment:
i think itd be good to keep them centrally defined here, but then put the
`expect(dead_code)` on them directly if possible instead of just at the module
level, so we at least have visibility on which methods it refers to
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
