HippoBaro commented on PR #11278: URL: https://github.com/apache/arrow-rs/pull/11278#issuecomment-5973275357
> after reading the issue and the PR descrtion I think this PR can be split into two seperate PR that target the ree & dictionary changes indepently. @Rich-T-kid I kept these together because the dictionary and REE fixes overlap heavily in the same schema normalization, compatibility checks, and level-generation code. They also interact directly: we need to handle both `Dictionary<REE<T>>` and `REE<Dictionary<T>>` consistently, especially around nullability. They could be separated, but a clean split would be a closely coupled pair of PRs where one introduces shared machinery that the other builds on, which I usually try to avoid since it makes reviewing more difficult. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
