HippoBaro commented on code in PR #11278:
URL: https://github.com/apache/arrow-rs/pull/11278#discussion_r4174779636
##########
parquet/src/arrow/arrow_writer/levels.rs:
##########
@@ -933,42 +967,36 @@ impl LevelInfoBuilder {
/// and the other is a native array, the dictionary values must have the
same type as the
/// native array
fn types_compatible(a: &DataType, b: &DataType) -> bool {
Review Comment:
Fair point. This goes beyond the minimal fix for the reported bugs.
For context, this commit was extracted from my native REE support series
(#11273), where the broader nested compatibility is needed. I kept it here
because it builds on the same recursive type-resolution and level-generation
changes.
My preference would be to keep these closely related pieces together rather
than split the series into more tightly dependent PRs, but I agree that the
scope is broader than this particular fix strictly requires.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
