anandghegde commented on code in PR #11078:
URL: https://github.com/apache/arrow-rs/pull/11078#discussion_r4183593658
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -81,20 +84,6 @@ pub use decimal::parse_string_to_decimal_native;
pub use decimal::{DecimalCast, rescale_decimal, single_float_to_decimal};
pub use string::cast_single_string_to_boolean_default;
-/// Lossy conversion from decimal to float.
-///
-/// Conversion is lossy and follows standard floating point semantics. Values
-/// that exceed the representable range become `INFINITY` or `-INFINITY`
without
-/// returning an error.
-#[inline(always)]
-pub fn single_decimal_to_float_lossy<D, F>(f: &F, x: D::Native, scale: i32) ->
f64
Review Comment:
Done in ca44f585: `single_decimal_to_float_lossy` stays in `cast/mod.rs`
where it was — the definition no longer appears in the diff. Only the private
adapters (`cast_from_decimal`, `cast_to_decimal`, `cast_integer_to_decimal`,
`integer_to_decimal_native`) move into the decimal submodule; its call sites
reach the helper through the existing `use crate::cast::*`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
