kszucs commented on code in PR #51685:
URL: https://github.com/apache/arrow/pull/51685#discussion_r4238659637
##########
cpp/src/parquet/column_writer.h:
##########
@@ -199,6 +204,22 @@ class PARQUET_EXPORT ColumnWriter {
int64_t num_levels, const ::arrow::Array&
leaf_array,
ArrowWriteContext* ctx,
bool leaf_field_nullable) = 0;
+
+ private:
+ friend class RowGroupSerializer;
+
+ /// \brief Create a column writer using the given level information and
content
+ /// defined chunker
+ ///
+ /// The file writer computes the level information of a column once and
gives the same
+ /// chunker to the column writers of a column, so the content defined
chunking is
+ /// carried over between the row groups. The chunker is required if the
properties
+ /// enable content defined chunking.
+ static std::shared_ptr<ColumnWriter> Make(
Review Comment:
It was split after the bot flagged an ABI break and silently disabled CDC
for existing callers, but the constructor now throws when CDC is enabled
without a chunker, so there's no reason to keep them separate. Folded it back
into the existing Make().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
