kszucs commented on code in PR #51685:
URL: https://github.com/apache/arrow/pull/51685#discussion_r4238645939
##########
cpp/src/parquet/file_writer.cc:
##########
@@ -139,14 +143,16 @@ class RowGroupSerializer : public
RowGroupWriter::Contents {
// Throws an error if more columns are being written
auto col_meta = metadata_->NextColumnChunk();
+ // Keep the ordinal in step with the metadata even if closing the previous
column
Review Comment:
It was meant to keep the column ordinal in step with the metadata if closing
the previous column writer throws and NextColumn() is called again. Otherwise
the new writer would pick up the previous column's chunker. That mismatch isn't
specific to CDC though (the page index and bloom filter builders are affected
the same way), and continuing after a failed close isn't really supported, so I
reverted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
