limadog9 opened a new pull request, #53870: URL: https://github.com/apache/arrow/pull/53870
Rationale for this change Closes #34389. GitHub can silently ignore an issue assignment when the contributor is not yet eligible to be assigned. The PR bot currently announces success even when the returned issue has no assignees. What changes are included in this PR? Send the assignees as an array and verify that the assignment response includes the PR creator before posting the success message. If assignment was ignored, link the issue and ask the contributor to leave a comment requesting assignment by a committer or collaborator, following the contributor documentation. Add dependency-free Node regression tests and run them in a read-only Dev workflow job. Are these changes tested? * node --test .github/workflows/dev_pr/*.test.js — 6 passed. Three cases fail with the original implementation. * Coverage includes successful assignment, silently ignored assignment, a different returned assignee, an already assigned issue, and unrelated PR titles. * JavaScript syntax checks, workflow YAML parsing, and git diff --check pass. Are there any user-facing changes? The bot reports assignment success only when GitHub confirms it. Contributors whose automatic assignment is rejected receive a link and instructions to request assignment instead of an incorrect success message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
