vikrantpuppala commented on code in PR #51342:
URL: https://github.com/apache/arrow/pull/51342#discussion_r4279721155
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/odbc_statement.cc:
##########
@@ -571,8 +576,9 @@ void ODBCStatement::SetStmtAttr(SQLINTEGER
statement_attribute, SQLPOINTER value
return;
}
case SQL_ATTR_APP_ROW_DESC: {
- ODBCDescriptor* desc = static_cast<ODBCDescriptor*>(value);
- if (desc && current_ard_ != desc) {
+ ODBCDescriptor* desc =
+ value ? static_cast<ODBCDescriptor*>(value) : built_in_ard_.get();
+ if (current_ard_ != desc) {
Review Comment:
Fixed in 550eea61ab. Switching the active ARD now marks the incoming
descriptor bindings as changed, and restoring the implicit ARD does the same. I
added fetch/switch/reset/fetch and active-descriptor-free regressions through
the direct driver API, plus manager-level coverage. The full local ODBC suite
passes (394 passed, 322 skipped).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
