CurtHagenlocher commented on code in PR #4895:
URL: https://github.com/apache/arrow-adbc/pull/4895#discussion_r4282513156
##########
csharp/src/Apache.Arrow.Adbc/AdbcConnection.cs:
##########
@@ -25,7 +27,12 @@ namespace Apache.Arrow.Adbc
/// Provides methods for query execution, managing prepared statements,
/// using transactions, and so on.
/// </summary>
- public abstract class AdbcConnection : IDisposable
+ /// <remarks>
+ /// Each asynchronous method has a default implementation that runs the
+ /// corresponding synchronous method on the thread pool and responds to its
+ /// <see cref="CancellationToken"/> by calling <see cref="Cancel"/>.
+ /// </remarks>
+ public abstract class AdbcConnection : IDisposable, IAsyncDisposable
Review Comment:
We get this interface from a package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
