Jefffrey commented on code in PR #11572:
URL: https://github.com/apache/arrow-rs/pull/11572#discussion_r4305319266
##########
arrow-cast/src/cast/mod.rs:
##########
@@ -5526,6 +5563,44 @@ mod tests {
);
}
+ #[test]
+ fn test_cast_string_to_duration() {
+ let array = StringArray::from(vec![Some("1"), Some("-2"), None,
Some("invalid")]);
Review Comment:
a good rule of thumb is to be able to roundtrip through the display
representation:
https://github.com/apache/arrow-rs/blob/6db2d4fd99c766ecd65a90419cea717ad5fbb619/arrow-cast/src/display.rs#L1591-L1613
can see how we display days here, so it would make sense to support parsing
days
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
