miguelcorderopamphile commented on code in PR #11572:
URL: https://github.com/apache/arrow-rs/pull/11572#discussion_r4305338170


##########
arrow-cast/src/cast/mod.rs:
##########
@@ -5526,6 +5563,44 @@ mod tests {
         );
     }
 
+    #[test]
+    fn test_cast_string_to_duration() {
+        let array = StringArray::from(vec![Some("1"), Some("-2"), None, 
Some("invalid")]);

Review Comment:
   Done in d047bf038 — days now convert at 24h/day (weeks fold into days in the 
parser), so pretty display strings roundtrip: `"45 days 14 hours 2 mins 34 
secs"` → 3938554s for Duration(s). Months stay non-convertible since the 
duration display never emits them.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to