CurtHagenlocher commented on PR #4919: URL: https://github.com/apache/arrow-adbc/pull/4919#issuecomment-6253168847
Re the review note about NaN and Infinity in variant JSON: variants use the same JSON writer as structs, and on `main` that writer already throws for non-finite float and double struct fields. Arrow's own `VariantJsonWriter` also rejects them. Since this predates this PR, it's fixed separately in #4921, which writes them as `"NaN"`, `"Infinity"` and `"-Infinity"`. Variants will get the same behavior through the shared writer; once #4921 merges, I'll add a variant regression test here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
