Copilot commented on code in PR #50629:
URL: https://github.com/apache/arrow/pull/50629#discussion_r4339164948
##########
cpp/src/parquet/column_reader_test.cc:
##########
@@ -1629,23 +1737,61 @@ TEST_P(FLBARecordReaderTest, ReadAndSkipOptional) {
record_reader_->Reset();
}
-INSTANTIATE_TEST_SUITE_P(ByteArrayRecordReaderTests, ByteArrayRecordReaderTest,
- testing::Bool());
+std::vector<ByteArrayRecordReaderParam> ByteArrayRecordReaderParams() {
+ std::vector<ByteArrayRecordReaderParam> params;
+ for (bool read_dense_for_nullable : {false, true}) {
+ for (bool read_dictionary : {false, true}) {
+ for (Encoding::type encoding : {Encoding::PLAIN,
Encoding::RLE_DICTIONARY}) {
+ for (bool allow_levels_optimization : {true, false}) {
Review Comment:
This parameter matrix includes `read_dictionary=true` with
`encoding=Encoding::PLAIN`. `MakePages` then emits plain data pages, but
`ByteArrayDictionaryRecordReader` requires dictionary encoding and will throw
when `ReadRecords` checks the page encoding, so these newly added test
instances fail. Filter out this combination or generate a dictionary page for
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
