lidavidm commented on code in PR #4937:
URL: https://github.com/apache/arrow-adbc/pull/4937#discussion_r4344990122
##########
dev/release/verify-release-candidate.sh:
##########
@@ -944,16 +959,21 @@ print(version.text)
fi
done
- mvn -B install:install-file \
- "${maven_repository_argument}" \
+ mvn "${maven_arguments[@]}" install:install-file \
"-Dfile=${jar_path}" \
"-DpomFile=${pom_path}" \
"-Dsources=${sources_path}" \
"-Djavadoc=${javadoc_path}"
done
- mvn -B test \
- "${maven_repository_argument}" \
+ local test_arguments=()
+ if [[ "$(uname)" == "Darwin" && "$(uname -m)" == "x86_64" ]]; then
+ show_info "Skipping testDriverJni: JNI binaries are not available for
macOS/x86_64"
+ test_arguments+=('-Dtest=!VerifyReleaseCandidateTest#testDriverJni')
+ fi
+
+ mvn "${maven_arguments[@]}" test \
+ "${test_arguments[@]}" \
Review Comment:
Want to file an issue and we can get this fixed for the next release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
