Arawoof06 commented on PR #51755: URL: https://github.com/apache/arrow/pull/51755#issuecomment-6342910742
Reviewed this against #50540. The 42 bound is correct for the current formatter, and the test reproduces the overlap nicely. The tradeoff is that the constant has to stay in sync with `StringFormatter<Date64Type>`, while #50540 sizes the block from the formatted output inside the callback and drops the guessed constants from both the date64 and float macros. Since the reviewer preferred exact sizing, I'd suggest landing #50540 and closing this one as a duplicate, if that works for you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
