Nayana-Naik73 commented on PR #51755: URL: https://github.com/apache/arrow/pull/51755#issuecomment-6360260756
Agreed, exact sizing is the better shape here. I had a read through #50540 and left a review there: allocating inside the callback from min(len, size) means nothing has to track the formatter any more, and the year 10000 and int64 min expectations in TestCastVARCHARFromMillisecondsLongOutput line up with what FormatYYYY_MM_DD and FormatOutOfRange actually produce, so my 9000000000000000 case is covered by the same out-of-range path. Happy for this one to be closed as a duplicate once #50540 goes in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
