rustyconover commented on PR #9445: URL: https://github.com/apache/arrow-rs/pull/9445#issuecomment-6347094063
Rebased onto current `main`. The writer side now attaches `custom_metadata` in `record_batch_to_bytes` after the record batch encoding refactor in #10128, and CI should be green again. @alamb @jhorstmann I think all the design feedback so far has been addressed (`arrow_schema::Metadata`, Arc-shared on clone, `RecordBatch` 40 → 48 bytes). Is there any remaining objection to adding the field to `RecordBatch`, or is this ready for an approving review? Happy to make further changes if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
