mbutrovich opened a new pull request, #11831: URL: https://github.com/apache/arrow-rs/pull/11831
# Which issue does this PR close? - Closes #11824. # Rationale for this change #10945 is not in a release yet, so this fix should go in 60.1.0 (#10525). This PR changes the same lines of `take_record_batch` as #11829, so it should merge after #11829. I will rebase it then. # What changes are included in this PR? `take_record_batch` builds its result with `RecordBatch::try_new_with_options` instead of `RecordBatch::new_unchecked`, so a null index into a non-nullable column returns the same error as 60.0.0. The row count keeps the result of a batch with no columns at `indices.len()` rows, as on `main`. # Are these changes tested? Yes, the new `test_take_record_batch_*` tests in `arrow-select/src/take.rs` cover a null index into non-nullable primitive, string, dictionary, struct, and fixed-size list columns, indices whose validity buffer has no nulls, and a batch with no columns. # Are there any significant user-facing changes? No. This restores the 60.0.0 behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
